Remove password history feature in iotdb.#17436
Open
wenyanshi-123 wants to merge 3 commits intoapache:masterfrom
Open
Remove password history feature in iotdb.#17436wenyanshi-123 wants to merge 3 commits intoapache:masterfrom
wenyanshi-123 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the password history-based authentication features (password expiration and password reuse interval) from IoTDB.
Changes:
- Removes password expiration/reuse configuration fields and their usage paths.
- Deletes
DataNodeAuthUtilsand strips post-success password-history recording from authorization statements. - Removes password-history verification from login flows and integration tests.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java |
Drops password expiration/reuse config fields; leaves related config surface to reassess. |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/DataNodeAuthUtils.java |
Deletes password history utilities (query/record/delete/expire/reuse checks). |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/sys/AuthorStatement.java |
Removes password-history recording on CREATE/ALTER/DROP USER success. |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/RelationalAuthorStatement.java |
Same as above for relational author statements. |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/TreeConfigTaskVisitor.java |
Removes password reuse interval enforcement during user password updates. |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/TableConfigTaskVisitor.java |
Removes password reuse interval enforcement during relational user password updates. |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/session/SessionManager.java |
Removes password-expiration checks and related login messaging/history creation. |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java |
Removes password-expiration checks during receiver login. |
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/audit/DNAuditLogger.java |
Removes the password history audit prefix constant. |
integration-test/src/test/java/org/apache/iotdb/db/it/auth/IoTDBAuthIT.java |
Removes password history integration tests and related imports. |
Comments suppressed due to low confidence (1)
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java:2731
mayBypassPasswordCheckInException(and its getter/setter) appears to be unused after removing the password history/expiration/reuse logic. Keeping a dead config knob is confusing for operators and future maintainers; consider removing this field and any corresponding config parsing/documentation if it was only intended to bypass password-history checks.
public boolean isMayBypassPasswordCheckInException() {
return mayBypassPasswordCheckInException;
}
public void setMayBypassPasswordCheckInException(boolean mayBypassPasswordCheckInException) {
this.mayBypassPasswordCheckInException = mayBypassPasswordCheckInException;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wenyanshi-123
force-pushed
the
removePasswordHistory
branch
from
2041297 to
2a6c6f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove password history feature in iotdb.